Skip to content

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

davidtwco and others added 20 commits February 8, 2023 15:09
Extend support for `implies_by` (from `#[stable]` and `#[unstable]`)
to `#[rustc_const_stable]` and `#[rustc_const_unstable]`.

Signed-off-by: David Wood <[email protected]>
Desugaring DropAndReplace at MIR build (rust-lang#107844) fixed issue
70919. Add regressions tests, borrowed from rust-lang#102078, to ensure we
check for this in the future.

Co-authored-by: Aaron Hill <[email protected]>
… r=Nilstrieb

const_eval: `implies_by` in `rustc_const_unstable`

Fixes rust-lang#107605.

Extend support for `implies_by` (from `#[stable]` and `#[unstable]`) to `#[rustc_const_stable]` and `#[rustc_const_unstable]`.

cc ``@steffahn``
Add regression tests for issue 70919

Desugaring DropAndReplace at MIR build (rust-lang#107844) fixed rust-lang#70919.
Add regressions tests, borrowed from rust-lang#102078, to ensure we check for this in the future.

cc ``@Aaron1011``
…-obk

Check for free regions in MIR validation

This turns rust-lang#108720 into a MIR validation failure that will reproduce without debug-assertions enabled.

```
error: internal compiler error: broken MIR in Item(WithOptConstParam { did: DefId(0:296 ~ futures_util[3805]::future::future::remote_handle::{impl#3}::poll), const_param_did: None }) (after pass ScalarReplacementOfAggregates) at bb0[0]:
                                Free regions in optimized runtime-post-cleanup MIR
  --> /home/ben/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-util-0.3.26/src/future/future/remote_handle.rs:96:13
   |
96 |         let this = self.project();
   |             ^^^^
```
Do not ICE when interpreting a cast between non-monomorphic types

Fixes rust-lang#101596
…li-obk

Do not ICE when failing to normalize in ConstProp.

There is no reason to delay a bug there, as we bubble up the failure as TooGeneric.

Fixes rust-lang#97728
…t_impls, r=lcnr

Emit the suspicious_auto_trait_impls for negative impls as well

Fixes rust-lang#108804
…rieb

Add regression test for rust-lang#98444

cc rust-lang#108730 this will need to be changed to a `check-fail` test once it lands.

Fixes rust-lang#98444
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Mar 6, 2023
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=8

@bors
Copy link
Collaborator

bors commented Mar 6, 2023

📌 Commit 567cab9 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 6, 2023
@bors
Copy link
Collaborator

bors commented Mar 6, 2023

⌛ Testing commit 567cab9 with merge 81be7b8...

@bors
Copy link
Collaborator

bors commented Mar 7, 2023

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 81be7b8 to master...

1 similar comment
@bors
Copy link
Collaborator

bors commented Mar 7, 2023

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 81be7b8 to master...

@bors bors added merged-by-bors This PR was explicitly merged by bors. labels Mar 7, 2023
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Perf Build Sha

previous master: 81be7b86d3

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@bors bors merged commit 81be7b8 into rust-lang:master Mar 7, 2023
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Perf Build Sha

previous master: 81be7b86d3

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rustbot rustbot added this to the 1.70.0 milestone Mar 7, 2023
@rust-timer
Copy link
Collaborator

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (81be7b8): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.3% [-0.3%, -0.3%] 3
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.8% [-2.8%, -2.8%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -2.8% [-2.8%, -2.8%] 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.